Skip to content

STM32MP2: add I2C support #92185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

STM32MP2: add I2C support #92185

wants to merge 10 commits into from
+162 −6

Conversation

TanguyRaufflet
Copy link

@TanguyRaufflet TanguyRaufflet commented Jun 25, 2025 •
edited
Loading

This PR adds I2C support for the STM32MP2 SoC series.

Signed-off-by: Tanguy Raufflet tanguy.raufflet@savoirfairelinux.com

@github-actions GitHub Actions
Copy link

Hello @TanguyRaufflet, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@JarmouniA JarmouniA requested review from arnopo June 25, 2025 19:12
@arnopo
Copy link
Contributor

arnopo commented Jun 26, 2025

To simplify the reviews could you split it in 2 PRs one per peripheral?
There is also compliance check issue to fix

@TanguyRaufflet TanguyRaufflet changed the title STM32MP2: add I2C and watchdog support STM32MP2: add I2C support Jun 26, 2025
@TanguyRaufflet
Copy link
Author

To simplify the reviews could you split it in 2 PRs one per peripheral? There is also compliance check issue to fix

Of course, I removed the watchdog-related commits. Since watchdog and i2c edit files in common, I'll post the PR with the watchdog integration after this one has been merged.

arnopo
arnopo reviewed Jun 27, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@468e5ad zephyrproject-rtos/hal_stm32#293 zephyrproject-rtos/hal_stm32#293/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 7, 2025
Tanguy Raufflet added 10 commits July 7, 2025 13:31
modules: hal_stm32: update the HAL to integrate I2C8 clock configuration
aa9b973 
Update hal_stm32 to include the modifications allowing to read the I2C8
clock frequency in the same way as I2C1-7.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
drivers: pinctrl: stm32: add gpioz pinctrl support for STM32MP2
36d6b49 
The STM32MP2 series needs gpioz pinctrl support to be able to use
the GPIOZ pins.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
drivers: gpio: stm32: add gpioz support for the STM32MP2
aa5fef3 
Add support for GPIOZ in the STM32 GPIO driver.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
dts: arm: st: stm32mp2_m33.dtsi: add node gpioz
ca2f0ff 
Add GPIO Z node to the device tree for STM32MP2 SoC.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
dt-bindings: stm32mp2_clock.h: add clock for i2c peripherals
a35791d 
Add clock bindings for I2C peripherals for the STM32MP2 series.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
drivers: clock_stm32_ll_mp2: add i2c clock
884c7ac 
Add I2C clocks rate reading to the STM32MP2 clock driver.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
drivers: i2c: Kconfig.stm32: enable combined interrupt for STM32MP2
18672ba 
According to the STM32MP2 reference manual, the I2C controller uses
a single interrupt line for all events (EV + ERR), so the combined
interrupt must be enabled for the STM32MP2 series.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
dts: arm: st: stm32mp2_m33.dtsi: add i2c nodes
0774d45 
Add I2C nodes in non-secure context to dtsi.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
boards: st: stm32mp257f_ev1_stm32mp257fxx_m33.yaml: update documentation
432fb47 
The I2C is now supported.

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
stm32mp257f_ev1_stm32mp257fxx_m33.dts: add i2c node
f038a95 
This commit adds the i2c8 node to the device tree for the
STM32MP257F-EV1 board. This node corresponds to the i2c exposed by the
GPIO expansion connector [1] and not used by the cortex A35.

[1]: https://wiki.st.com/stm32mpu/wiki/STM32MP257x-EV1_-_hardware_description

Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnopo arnopo arnopo approved these changes

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@erwango erwango Awaiting requested review from erwango

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@katsuster katsuster Awaiting requested review from katsuster

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@teburd teburd Awaiting requested review from teburd

@gmarull gmarull Awaiting requested review from gmarull

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

At least 2 approving reviews are required to merge this pull request.

Assignees

@nordic-krch nordic-krch

Labels
area: Clock Control area: GPIO area: I2C area: Pinctrl area: Watchdog Watchdog DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_stm32 platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TanguyRaufflet @arnopo @nordic-krch